[exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck

[exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck

CommitSurfaceHierarchy() moves pending_frame_callbacks_ into 
frame_callbacks_ before calling UpdateSurface() so that the ack doesn't
arrive too early.

exo::Surface is the only class which needs 
MojoCompositorFrameSinkClient::WillDrawSurface(). With this change, we
can remove WillDrawSurface from the mojo interface and reduce IPC overhead.

BUG=671202, 709076
Review-Url: https://codereview.chromium.org/2786643002
Cr-Commit-Position: refs/heads/master@{#462678}
Committed: https://chromium.googlesource.com/chromium/src/+/09b06cad7bc4b38fa64142b16a0c6adcbcc875b4

[Alex Z., 2017-04-06 19:33:49]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 19:34:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 20:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 20:07:12]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2017-04-06 20:32:19]

Description was changed from

==========
[exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck

NOT FOR COMMIT

BUG=
==========

to

==========
[exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck

CommitSurfaceHierarchy() moves pending_frame_callbacks_ into 
frame_callbacks_ before calling UpdateSurface() so that the ack doesn't
arrive too early.

exo::Surface is the only class which needs 
MojoCompositorFrameSinkClient::WillDrawSurface(). With this change, we
can remove WillDrawSurface from the mojo interface and reduce IPC overhead.

BUG=
==========

[Alex Z., 2017-04-06 20:32:19]

staraz@chromium.org changed reviewers:
+ fsamuel@google.com, reveman@chromium.org

[Alex Z., 2017-04-06 20:37:03]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 20:38:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2017-04-06 20:42:04]

lgtm with nit

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
File components/exo/compositor_frame_sink_holder.cc (right):

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
components/exo/compositor_frame_sink_holder.cc:44: // TODO(staraz): Implement
this
nit: remove this now?

[Alex Z., 2017-04-06 20:49:07]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2017-04-06 20:49:14]

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
File components/exo/compositor_frame_sink_holder.cc (right):

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
components/exo/compositor_frame_sink_holder.cc:44: // TODO(staraz): Implement
this
On 2017/04/06 20:42:04, reveman wrote:
> nit: remove this now?

Done.

[commit-bot: I haz the power, 2017-04-06 20:50:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-04-06 20:52:33]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-04-06 20:52:33]

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
File components/exo/compositor_frame_sink_holder.cc (right):

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
components/exo/compositor_frame_sink_holder.cc:46: surface_->WillDraw();
Rename WillDraw to DidReceiveCompositorFrameAck?

[reveman, 2017-04-06 21:09:06]

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
File components/exo/compositor_frame_sink_holder.cc (right):

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
components/exo/compositor_frame_sink_holder.cc:46: surface_->WillDraw();
On 2017/04/06 at 20:52:33, Fady Samuel wrote:
> Rename WillDraw to DidReceiveCompositorFrameAck?

+1

[Alex Z., 2017-04-06 21:11:01]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2017-04-06 21:11:12]

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
File components/exo/compositor_frame_sink_holder.cc (right):

https://codereview.chromium.org/2786643002/diff/80001/components/exo/composit...
components/exo/compositor_frame_sink_holder.cc:46: surface_->WillDraw();
On 2017/04/06 20:52:33, Fady Samuel wrote:
> Rename WillDraw to DidReceiveCompositorFrameAck?

Done.

[commit-bot: I haz the power, 2017-04-06 21:11:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-04-06 21:18:49]

LGTM. Please specify the bug number.

[Alex Z., 2017-04-06 21:23:26]

Description was changed from

==========
[exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck

CommitSurfaceHierarchy() moves pending_frame_callbacks_ into 
frame_callbacks_ before calling UpdateSurface() so that the ack doesn't
arrive too early.

exo::Surface is the only class which needs 
MojoCompositorFrameSinkClient::WillDrawSurface(). With this change, we
can remove WillDrawSurface from the mojo interface and reduce IPC overhead.

BUG=
==========

to

==========
[exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck

CommitSurfaceHierarchy() moves pending_frame_callbacks_ into 
frame_callbacks_ before calling UpdateSurface() so that the ack doesn't
arrive too early.

exo::Surface is the only class which needs 
MojoCompositorFrameSinkClient::WillDrawSurface(). With this change, we
can remove WillDrawSurface from the mojo interface and reduce IPC overhead.

BUG=671202, 709076
==========

[Alex Z., 2017-04-06 21:23:45]

On 2017/04/06 21:18:49, Fady Samuel wrote:
> LGTM. Please specify the bug number.

Done.

[commit-bot: I haz the power, 2017-04-06 22:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 22:19:45]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2017-04-06 23:05:39]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-04-06 23:05:39]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2786643002/#ps120001
(title: "Address A Comment")

[commit-bot: I haz the power, 2017-04-06 23:06:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:27:27]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491519939355180,
"parent_rev": "58f84757e7003f5dcb3740d29227c02c84622162", "commit_rev":
"09b06cad7bc4b38fa64142b16a0c6adcbcc875b4"}

[commit-bot: I haz the power, 2017-04-06 23:28:17]

Description was changed from

==========
[exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck

CommitSurfaceHierarchy() moves pending_frame_callbacks_ into 
frame_callbacks_ before calling UpdateSurface() so that the ack doesn't
arrive too early.

exo::Surface is the only class which needs 
MojoCompositorFrameSinkClient::WillDrawSurface(). With this change, we
can remove WillDrawSurface from the mojo interface and reduce IPC overhead.

BUG=671202, 709076
==========

to

==========
[exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck

CommitSurfaceHierarchy() moves pending_frame_callbacks_ into 
frame_callbacks_ before calling UpdateSurface() so that the ack doesn't
arrive too early.

exo::Surface is the only class which needs 
MojoCompositorFrameSinkClient::WillDrawSurface(). With this change, we
can remove WillDrawSurface from the mojo interface and reduce IPC overhead.

BUG=671202, 709076

Review-Url: https://codereview.chromium.org/2786643002
Cr-Commit-Position: refs/heads/master@{#462678}
Committed:
https://chromium.googlesource.com/chromium/src/+/09b06cad7bc4b38fa64142b16a0c...
==========

[commit-bot: I haz the power, 2017-04-06 23:28:18]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/09b06cad7bc4b38fa64142b16a0c...