Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: extensions/browser/extension_protocols.cc

Issue 2786583002: chromeos: Check both original and absolute paths for file: scheme (Closed)
Patch Set: absolute_path -> original_path Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_protocols.cc
diff --git a/extensions/browser/extension_protocols.cc b/extensions/browser/extension_protocols.cc
index c1ea0a9b3e33ae7f1656ae6bb8c9fc3018f013a2..259a37c677c5da22644e0eb0d27dcfc5bf0650ec 100644
--- a/extensions/browser/extension_protocols.cc
+++ b/extensions/browser/extension_protocols.cc
@@ -284,6 +284,14 @@ class URLRequestExtensionJob : public net::URLRequestFileJob {
request_timer_->Elapsed());
}
+ bool CanAccessFile(const base::FilePath& original_path,
+ const base::FilePath& absolute_path) override {
+ // The access checks for the file are performed before the job is
+ // created, so we should know that this is safe.
+ DCHECK(directory_path_.IsParent(original_path));
+ return true;
+ }
+
void OnFilePathAndLastModifiedTimeRead(base::FilePath* read_file_path,
base::Time* last_modified_time) {
file_path_ = *read_file_path;

Powered by Google App Engine
This is Rietveld 408576698