net/url_request/file_protocol_handler.cc - Issue 2786583002: chromeos: Check both original and absolute paths for file: scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/file_protocol_handler.cc

Issue 2786583002: chromeos: Check both original and absolute paths for file: scheme (Closed)

Patch Set: add null checks for network_delegate() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/file_protocol_handler.cc

diff --git a/net/url_request/file_protocol_handler.cc b/net/url_request/file_protocol_handler.cc

index ceed930985cd8514ca2d7c9b1209af5e71b5880b..e3c6edf44dea62dd4cbf119e4375c95af9a970bc 100644

--- a/net/url_request/file_protocol_handler.cc

+++ b/net/url_request/file_protocol_handler.cc

@@ -26,9 +26,7 @@ URLRequestJob* FileProtocolHandler::MaybeCreateJob(

base::FilePath file_path;

const bool is_file = FileURLToFilePath(request->url(), &file_path);

- // Check file access permissions.

- if (!network_delegate ||

- !network_delegate->CanAccessFile(*request, file_path)) {

+ if (!network_delegate) {

return new URLRequestErrorJob(request, network_delegate, ERR_ACCESS_DENIED);

}