Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: net/base/layered_network_delegate_unittest.cc

Issue 2786583002: chromeos: Check both original and absolute paths for file: scheme (Closed)
Patch Set: add null checks for network_delegate() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/layered_network_delegate_unittest.cc
diff --git a/net/base/layered_network_delegate_unittest.cc b/net/base/layered_network_delegate_unittest.cc
index cd9f5d2443c286bf657e7a44c39c506bebeaff8c..2c16702a383d4db5402ddf82aaf896544fa31147 100644
--- a/net/base/layered_network_delegate_unittest.cc
+++ b/net/base/layered_network_delegate_unittest.cc
@@ -128,7 +128,8 @@ class TestNetworkDelegateImpl : public NetworkDelegateImpl {
}
bool OnCanAccessFile(const URLRequest& request,
- const base::FilePath& path) const override {
+ const base::FilePath& original_path,
+ const base::FilePath& absolute_path) const override {
IncrementAndCompareCounter("on_can_access_file_count");
return false;
}
@@ -205,7 +206,7 @@ class TestLayeredNetworkDelegate : public LayeredNetworkDelegate {
OnAuthRequired(request.get(), *auth_challenge, AuthCallback(), NULL));
EXPECT_FALSE(OnCanGetCookies(*request, CookieList()));
EXPECT_FALSE(OnCanSetCookie(*request, std::string(), NULL));
- EXPECT_FALSE(OnCanAccessFile(*request, base::FilePath()));
+ EXPECT_FALSE(OnCanAccessFile(*request, base::FilePath(), base::FilePath()));
EXPECT_FALSE(OnCanEnablePrivacyMode(GURL(), GURL()));
EXPECT_FALSE(OnCancelURLRequestWithPolicyViolatingReferrerHeader(
*request, GURL(), GURL()));
@@ -310,8 +311,10 @@ class TestLayeredNetworkDelegate : public LayeredNetworkDelegate {
EXPECT_EQ(1, (*counters_)["on_can_set_cookie_count"]);
}
- void OnCanAccessFileInternal(const URLRequest& request,
- const base::FilePath& path) const override {
+ void OnCanAccessFileInternal(
+ const URLRequest& request,
+ const base::FilePath& original_path,
+ const base::FilePath& absolute_path) const override {
++(*counters_)["on_can_access_file_count"];
EXPECT_EQ(1, (*counters_)["on_can_access_file_count"]);
}

Powered by Google App Engine
This is Rietveld 408576698