Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: chrome/browser/android/offline_pages/offline_page_request_job.h

Issue 2786583002: chromeos: Check both original and absolute paths for file: scheme (Closed)
Patch Set: add null checks for network_delegate() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_request_job.h
diff --git a/chrome/browser/android/offline_pages/offline_page_request_job.h b/chrome/browser/android/offline_pages/offline_page_request_job.h
index 500af977a082b287095fe5374facf7025545ac20..dc75abf5212843da9de333c3bab082a05e651ea7 100644
--- a/chrome/browser/android/offline_pages/offline_page_request_job.h
+++ b/chrome/browser/android/offline_pages/offline_page_request_job.h
@@ -103,6 +103,13 @@ class OfflinePageRequestJob : public net::URLRequestFileJob {
void SetDelegateForTesting(std::unique_ptr<Delegate> delegate);
private:
+ // Returns true to disable the file patch checking for file: scheme in
+ // URLRequestFileJob, that's not relevant for this class.
+ bool CanAccessFile(const base::FilePath& original_path,
+ const base::FilePath& absolute_path) override {
+ return true;
+ }
+
OfflinePageRequestJob(net::URLRequest* request,
net::NetworkDelegate* network_delegate,
previews::PreviewsDecider* previews_decider);

Powered by Google App Engine
This is Rietveld 408576698