Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: net/url_request/file_protocol_handler.cc

Issue 2786583002: chromeos: Check both original and absolute paths for file: scheme (Closed)
Patch Set: disable checks in sub classes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/file_protocol_handler.cc
diff --git a/net/url_request/file_protocol_handler.cc b/net/url_request/file_protocol_handler.cc
index ceed930985cd8514ca2d7c9b1209af5e71b5880b..e3c6edf44dea62dd4cbf119e4375c95af9a970bc 100644
--- a/net/url_request/file_protocol_handler.cc
+++ b/net/url_request/file_protocol_handler.cc
@@ -26,9 +26,7 @@ URLRequestJob* FileProtocolHandler::MaybeCreateJob(
base::FilePath file_path;
const bool is_file = FileURLToFilePath(request->url(), &file_path);
- // Check file access permissions.
- if (!network_delegate ||
- !network_delegate->CanAccessFile(*request, file_path)) {
+ if (!network_delegate) {
return new URLRequestErrorJob(request, network_delegate, ERR_ACCESS_DENIED);
}
mmenke 2017/04/18 17:24:46 This should probably also be moved into the job cl
satorux1 2017/04/21 08:05:37 Moving to Job classes broke net_unittests as the t

Powered by Google App Engine
This is Rietveld 408576698