Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: net/base/layered_network_delegate_unittest.cc

Issue 2786583002: chromeos: Check both original and absolute paths for file: scheme (Closed)
Patch Set: disable checks in sub classes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/layered_network_delegate_unittest.cc
diff --git a/net/base/layered_network_delegate_unittest.cc b/net/base/layered_network_delegate_unittest.cc
index f1d07bc47ac8cc2b5355d2f0165577b93eba85c2..9530fc37d509ce826b1ec02302288b82ed2a8a78 100644
--- a/net/base/layered_network_delegate_unittest.cc
+++ b/net/base/layered_network_delegate_unittest.cc
@@ -127,7 +127,8 @@ class TestNetworkDelegateImpl : public NetworkDelegateImpl {
}
bool OnCanAccessFile(const URLRequest& request,
- const base::FilePath& path) const override {
+ const base::FilePath& original_path,
+ const base::FilePath& absolute_path) const override {
IncrementAndCompareCounter("on_can_access_file_count");
return false;
}
@@ -204,7 +205,7 @@ class TestLayeredNetworkDelegate : public LayeredNetworkDelegate {
OnAuthRequired(request.get(), *auth_challenge, AuthCallback(), NULL));
EXPECT_FALSE(OnCanGetCookies(*request, CookieList()));
EXPECT_FALSE(OnCanSetCookie(*request, std::string(), NULL));
- EXPECT_FALSE(OnCanAccessFile(*request, base::FilePath()));
+ EXPECT_FALSE(OnCanAccessFile(*request, base::FilePath(), base::FilePath()));
EXPECT_FALSE(OnCanEnablePrivacyMode(GURL(), GURL()));
EXPECT_FALSE(OnCancelURLRequestWithPolicyViolatingReferrerHeader(
*request, GURL(), GURL()));
@@ -309,8 +310,10 @@ class TestLayeredNetworkDelegate : public LayeredNetworkDelegate {
EXPECT_EQ(1, (*counters_)["on_can_set_cookie_count"]);
}
- void OnCanAccessFileInternal(const URLRequest& request,
- const base::FilePath& path) const override {
+ void OnCanAccessFileInternal(
+ const URLRequest& request,
+ const base::FilePath& original_path,
+ const base::FilePath& absolute_path) const override {
++(*counters_)["on_can_access_file_count"];
EXPECT_EQ(1, (*counters_)["on_can_access_file_count"]);
}

Powered by Google App Engine
This is Rietveld 408576698