Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2786493006: [logging] Quickfix for uninitialized timer in code-deopt event. (Closed)

Created:
3 years, 8 months ago by Jarin
Modified:
3 years, 8 months ago
Reviewers:
Leszek Swirski
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[logging] Quickfix for uninitialized timer in code-deopt event. Perhaps it would be better to always start the timer, but that would require some refactoring of tests. Review-Url: https://codereview.chromium.org/2786493006 Cr-Commit-Position: refs/heads/master@{#44425} Committed: https://chromium.googlesource.com/v8/v8/+/52bfe796f4018114438a12d614dd53787793e250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/log.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Jarin
Could you take a look, please?
3 years, 8 months ago (2017-03-29 15:06:28 UTC) #2
Leszek Swirski
lgtm
3 years, 8 months ago (2017-03-30 15:52:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786493006/1
3 years, 8 months ago (2017-04-06 07:07:55 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 07:31:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/52bfe796f4018114438a12d614dd5378779...

Powered by Google App Engine
This is Rietveld 408576698