Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2786493004: [Chromecast] Fix bug when audio device ID is empty string. (Closed)

Created:
3 years, 8 months ago by jameswest
Modified:
3 years, 8 months ago
Reviewers:
slan, halliwell, kmackay
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix bug when audio device ID is empty string. BUG=internal b/36563551 Review-Url: https://codereview.chromium.org/2786493004 Cr-Commit-Position: refs/heads/master@{#460515} Committed: https://chromium.googlesource.com/chromium/src/+/a542c2ef2954f2ffdcf742842fa79a99e1d9701c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chromecast/media/service/cast_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/service/cast_renderer.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jameswest
3 years, 8 months ago (2017-03-29 04:11:41 UTC) #3
kmackay
3 years, 8 months ago (2017-03-29 04:14:41 UTC) #5
kmackay
lgtm
3 years, 8 months ago (2017-03-29 04:15:21 UTC) #6
slan
lgtm
3 years, 8 months ago (2017-03-29 04:29:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786493004/1
3 years, 8 months ago (2017-03-29 19:30:47 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:20:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a542c2ef2954f2ffdcf742842fa7...

Powered by Google App Engine
This is Rietveld 408576698