Inline SelectorQuery::executeForTraverseRoots into findTraverseRootsAndExecute.

Inline SelectorQuery::executeForTraverseRoots into findTraverseRootsAndExecute.

This function is just a glorified if statement over the enum value we pass
into it. Inline the two loops into the call sites. We can also remove the
check against SelectorQueryTrait::shouldOnlyMatchFirstElement inside the loops
since the outer check ensures it's always false.

This lets us remove the MatchTraverseRootState enum. It does make the
findTraverseRootsAndExecute function bigger, but it removes a bunch of
checks in the process. Future patches will simplify further and hopefully
shrink the function.

BUG=703900
Review-Url: https://codereview.chromium.org/2786493003
Cr-Commit-Position: refs/heads/master@{#460448}
Committed: https://chromium.googlesource.com/chromium/src/+/7283eda4c582d4aa64838377970466ae6a4d2f2e

[esprehn, 2017-03-28 23:47:28]

Description was changed from

==========
Inline SelectorQuery::executeForTraverseRoots into findTraverseRootsAndExecute.

BUG=703900
==========

to

==========
Inline SelectorQuery::executeForTraverseRoots into findTraverseRootsAndExecute.

This function is just a glorified if statement over the enum value we pass
into it. Inline the two loops into the call sites. We can also remove the
check against SelectorQueryTrait::shouldOnlyMatchFirstElement inside the loops
since the outer check ensures it's always false.

This lets us remove the MatchTraverseRootState enum. It does make the
findTraverseRootsAndExecute function bigger, but it removes a bunch of
checks in the process. Future patches will simplify further and hopefully
shrink the function.

BUG=703900
==========

[esprehn, 2017-03-28 23:47:32]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 23:48:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:35:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:35:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[esprehn, 2017-03-29 01:44:32]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 01:45:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:50:31]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[esprehn, 2017-03-29 02:28:52]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 02:29:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 04:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 04:31:08]

Dry run: Exceeded global retry quota

[esprehn, 2017-03-29 05:00:43]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org, meade@chromium.org, rune@opera.com

[esprehn, 2017-03-29 05:00:43]

https://codereview.chromium.org/2786493003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/2786493003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SelectorQuery.cpp:291: break;
This was just executing the code below if we had not found anything in the loop,
the break achieves the same result.

[rune, 2017-03-29 09:38:46]

That looked over-engineered.

lgtm

[esprehn, 2017-03-29 17:44:56]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:45:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:50:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490809496420910, "parent_rev":
"e9637327dcc73c3d4abc94874d353e093436fe49", "commit_rev":
"7283eda4c582d4aa64838377970466ae6a4d2f2e"}

[commit-bot: I haz the power, 2017-03-29 17:51:35]

Description was changed from

==========
Inline SelectorQuery::executeForTraverseRoots into findTraverseRootsAndExecute.

This function is just a glorified if statement over the enum value we pass
into it. Inline the two loops into the call sites. We can also remove the
check against SelectorQueryTrait::shouldOnlyMatchFirstElement inside the loops
since the outer check ensures it's always false.

This lets us remove the MatchTraverseRootState enum. It does make the
findTraverseRootsAndExecute function bigger, but it removes a bunch of
checks in the process. Future patches will simplify further and hopefully
shrink the function.

BUG=703900
==========

to

==========
Inline SelectorQuery::executeForTraverseRoots into findTraverseRootsAndExecute.

This function is just a glorified if statement over the enum value we pass
into it. Inline the two loops into the call sites. We can also remove the
check against SelectorQueryTrait::shouldOnlyMatchFirstElement inside the loops
since the outer check ensures it's always false.

This lets us remove the MatchTraverseRootState enum. It does make the
findTraverseRootsAndExecute function bigger, but it removes a bunch of
checks in the process. Future patches will simplify further and hopefully
shrink the function.

BUG=703900

Review-Url: https://codereview.chromium.org/2786493003
Cr-Commit-Position: refs/heads/master@{#460448}
Committed:
https://chromium.googlesource.com/chromium/src/+/7283eda4c582d4aa648383779704...
==========

[commit-bot: I haz the power, 2017-03-29 17:51:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7283eda4c582d4aa648383779704...