Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2786473003: Fix one gn check failure of cast for Android build (Closed)

Created:
3 years, 8 months ago by AndyWu
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix one gn check failure of cast for Android build We moved mojo_media_host to browser process when CMA backend is enabled. The gn dependency //media/mojo/services is missing from //media/gpu. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2786473003 Cr-Commit-Position: refs/heads/master@{#460555} Committed: https://chromium.googlesource.com/chromium/src/+/defb02ed569af74c118368ac2c8a35b76c71b1b9

Patch Set 1 #

Patch Set 2 : nogncheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/gpu/android_video_decode_accelerator.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
AndyWu
3 years, 8 months ago (2017-03-29 19:17:44 UTC) #4
DaleCurtis
lgtm
3 years, 8 months ago (2017-03-29 20:00:46 UTC) #5
xhwang
not lgtm for now Could you please clarify what your setup is? Are you running ...
3 years, 8 months ago (2017-03-29 20:05:03 UTC) #6
xhwang
lgtm
3 years, 8 months ago (2017-03-29 20:50:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786473003/20001
3 years, 8 months ago (2017-03-29 21:03:39 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 22:29:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/defb02ed569af74c118368ac2c8a...

Powered by Google App Engine
This is Rietveld 408576698