Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.h

Issue 2786463004: Paint backgrounds of a table section/row in one display item (Closed)
Patch Set: - Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.h b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
index e1d9e970e49c2a94e7acba2a0c5f789209a7d60f..a663ba824cd74b00b6e950b757c1fb6aadf81ffc 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
@@ -320,29 +320,10 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
CollapsedBorderValue m_afterBorder;
};
- class RowBackgroundDisplayItemClient : public DisplayItemClient {
- public:
- RowBackgroundDisplayItemClient(const LayoutTableCell&);
-
- // DisplayItemClient methods.
- String debugName() const;
- LayoutRect visualRect() const;
-
- private:
- const LayoutTableCell& m_layoutTableCell;
- };
-
bool usesCompositedCellDisplayItemClients() const;
const CollapsedBorderValues* collapsedBorderValues() const {
return m_collapsedBorderValues.get();
}
- const DisplayItemClient& backgroundDisplayItemClient() const {
- return (m_rowBackgroundDisplayItemClient &&
- usesCompositedCellDisplayItemClients())
- ? static_cast<const DisplayItemClient&>(
- *m_rowBackgroundDisplayItemClient)
- : *this;
- }
LayoutRect debugRect() const override;
@@ -351,8 +332,6 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
// A table cell's location is relative to its containing section.
LayoutBox* locationContainer() const override { return section(); }
- void ensureIsReadyForPaintInvalidation() override;
-
bool hasLineIfEmpty() const override;
protected:
@@ -454,8 +433,6 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
int m_intrinsicPaddingAfter;
std::unique_ptr<CollapsedBorderValues> m_collapsedBorderValues;
- std::unique_ptr<RowBackgroundDisplayItemClient>
- m_rowBackgroundDisplayItemClient;
};
DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableCell, isTableCell());

Powered by Google App Engine
This is Rietveld 408576698