Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Issue 2786463004: Paint backgrounds of a table section/row in one display item (Closed)
Patch Set: - Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
index f10f6cedcf210fca9c0f990dd5e8dff9d81ee92b..3b9f24f9362feda0bf8605b29a3b9b16ffaff527 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
@@ -48,7 +48,6 @@ struct SameSizeAsLayoutTableCell : public LayoutBlockFlow {
unsigned bitfields;
int paddings[2];
void* pointer1;
- void* pointer2;
};
static_assert(sizeof(LayoutTableCell) == sizeof(SameSizeAsLayoutTableCell),
@@ -467,16 +466,6 @@ int LayoutTableCell::cellBaselinePosition() const {
return (borderBefore() + paddingBefore() + contentLogicalHeight()).toInt();
}
-void LayoutTableCell::ensureIsReadyForPaintInvalidation() {
- LayoutBlockFlow::ensureIsReadyForPaintInvalidation();
- if (!usesCompositedCellDisplayItemClients())
- return;
- if (!m_rowBackgroundDisplayItemClient) {
- m_rowBackgroundDisplayItemClient = WTF::wrapUnique(
- new LayoutTableCell::RowBackgroundDisplayItemClient(*this));
- }
-}
-
void LayoutTableCell::styleDidChange(StyleDifference diff,
const ComputedStyle* oldStyle) {
DCHECK_EQ(style()->display(), EDisplay::kTableCell);
@@ -522,18 +511,6 @@ void LayoutTableCell::styleDidChange(StyleDifference diff,
}
}
-LayoutTableCell::RowBackgroundDisplayItemClient::RowBackgroundDisplayItemClient(
- const LayoutTableCell& layoutTableCell)
- : m_layoutTableCell(layoutTableCell) {}
-
-String LayoutTableCell::RowBackgroundDisplayItemClient::debugName() const {
- return "RowBackground";
-}
-
-LayoutRect LayoutTableCell::RowBackgroundDisplayItemClient::visualRect() const {
- return m_layoutTableCell.row()->visualRect();
-}
-
// The following rules apply for resolving conflicts and figuring out which
// border to use.
// (1) Borders with the 'border-style' of 'hidden' take precedence over all
@@ -1471,10 +1448,6 @@ void LayoutTableCell::invalidateDisplayItemClients(
ObjectPaintInvalidator invalidator(*this);
if (m_collapsedBorderValues)
invalidator.invalidateDisplayItemClient(*m_collapsedBorderValues, reason);
- if (m_rowBackgroundDisplayItemClient) {
- invalidator.invalidateDisplayItemClient(*m_rowBackgroundDisplayItemClient,
- reason);
- }
}
// TODO(lunalu): Deliberately dump the "inner" box of table cells, since that
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.h ('k') | third_party/WebKit/Source/core/layout/LayoutTableRow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698