Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2786433004: Support for OpenType Font Variations on Windows (Closed)

Created:
2 years, 8 months ago by bungeman-skia
Modified:
2 years, 8 months ago
Reviewers:
drott
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support for OpenType Font Variations on Windows Enable support for variable fonts on Windows through using SkFontMgr_Custom_Empty, a FreeType backed font blob only SkTypeface factory (no access to system fonts). We will use a hybrid DirectWrite and FreeType font stack on Windows for at least as long as most of Windows versions we support with Chrome still do not have native support for font variations. Thanks to Ben Wagner for the help with enabling and prototyping this. BUG=700926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M DEPS View 2 chunks +17 lines, -0 lines 0 comments Download
M skia/BUILD.gn View 5 chunks +24 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
drott
Nice, thanks!
2 years, 8 months ago (2017-03-30 11:37:54 UTC) #2
bungeman-skia
On 2017/03/30 11:37:54, drott wrote: > Nice, thanks! Just curious, why is the win10 bot ...
2 years, 8 months ago (2017-03-30 14:48:53 UTC) #3
bungeman-skia
Closing this since the original https://codereview.chromium.org/2780133002/ can now proceed. This CL was mostly for experimenting ...
2 years, 8 months ago (2017-03-30 15:33:04 UTC) #5
drott
2 years, 8 months ago (2017-03-30 15:55:37 UTC) #6
Message was sent while issue was closed.
On 2017/03/30 at 14:48:53, bungeman wrote:
> On 2017/03/30 11:37:54, drott wrote:
> > Nice, thanks!
> 
> Just curious, why is the win10 bot green? Is it possible the tests don't fail
if some named variation is chosen? To clarify, on win10 DirectWrite (currently)
variations are 'supported' but there is no API. When we open a font like this we
get back all of the named instances as if the font file were a ttc font file.
Currently I believe we just pick the first one because we don't really know what
else to do. If that first one happens to line up with something that makes the
test pass, the test will pass. Mostly just curious, because I expected all of
the 'NeverFixTest' to start to fail (by passing) on both win7 and win10.

The test uses a web font. Win10 is green since the comparison between the
FreeType variation rendering and the DWrite non-variation reference rendering
happens to be identical. Whereas on Win7 there are slight antialiasing
differences. In the new CL, I am updating the reftest to make both glyphs be
produced by the variations font path, but using a dummy variation parameter
value.

Powered by Google App Engine
This is Rietveld 408576698