Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2786433003: Fix git cl format for actions.xml changes. (Closed)

Created:
3 years, 8 months ago by Alexei Svitkine (slow)
Modified:
3 years, 8 months ago
Reviewers:
Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix git cl format for actions.xml changes. Makes tools/metrics/actions follow the convention used in tools/metrics/histograms and tools/metrics/rappor of having a pretty_print.py file that formats the XML file. This is what git cl format expects. BUG=706501 Review-Url: https://codereview.chromium.org/2786433003 Cr-Commit-Position: refs/heads/master@{#460546} Committed: https://chromium.googlesource.com/chromium/src/+/c5f0349b6e01219686c8d0e76884553125f1aae9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A tools/metrics/actions/pretty_print.py View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Alexei Svitkine (slow)
3 years, 8 months ago (2017-03-29 19:10:27 UTC) #3
Mark P
looks good to me though frankly I'm not really qualified to do a python tooling ...
3 years, 8 months ago (2017-03-29 19:36:18 UTC) #4
Mark P
lgtm that is
3 years, 8 months ago (2017-03-29 19:36:26 UTC) #5
Alexei Svitkine (slow)
It follows the same style as rappor/pretty_print.py - mostly just boilerplate. :)
3 years, 8 months ago (2017-03-29 19:37:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786433003/1
3 years, 8 months ago (2017-03-29 19:37:55 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 22:06:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c5f0349b6e01219686c8d0e76884...

Powered by Google App Engine
This is Rietveld 408576698