Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2786413003: PPC/s390: [es2015] Simplify contract between parser and stub for derived constructors. (Closed)

Created:
3 years, 8 months ago by JaideepBajwa
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [es2015] Simplify contract between parser and stub for derived constructors. Port 776d89f9ce6e043972c1e611aa8cfaf2feb1fb78 Original Commit Message: Rewrite returns in derived constructors to only replace undefined with this, and otherwise just return the value, and let the construct stub builtin throw an exception if the result is a primitive instead of a JSReceiver. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:706642 LOG=N Review-Url: https://codereview.chromium.org/2786413003 Cr-Commit-Position: refs/heads/master@{#44315} Committed: https://chromium.googlesource.com/v8/v8/+/889d205b523c19e34c75770ff045a4c65d530635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 8 months ago (2017-03-31 16:18:57 UTC) #1
john.yan
lgtm
3 years, 8 months ago (2017-03-31 16:19:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786413003/1
3 years, 8 months ago (2017-03-31 16:19:57 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 16:45:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/889d205b523c19e34c75770ff045a4c65d5...

Powered by Google App Engine
This is Rietveld 408576698