Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2786313006:
MD Settings: Fix native languge name wrapping. (Closed)
|
Created:
3 years, 8 months ago by dpapad Modified:
3 years, 8 months ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Fix native languge name wrapping.
BUG=703977
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2786313006
Cr-Commit-Position: refs/heads/master@{#461230}
Committed: https://chromium.googlesource.com/chromium/src/+/cf1cb4ef559d87d9814200e9005437c3643a57cb
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== MD Settings: Fix native languge name wrapping. BUG=703977 ========== to ========== MD Settings: Fix native languge name wrapping. BUG=703977 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dpapad@chromium.org changed reviewers: + scottchen@chromium.org
Before/after http://imgur.com/a/PbrtI
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/31 17:50:13, dpapad wrote: > Before/after http://imgur.com/a/PbrtI lgtm, though I'm curious why the left-right-mark makes it wrap in the first place (http://imgur.com/a/Yj5uX)
On 2017/03/31 at 20:00:26, scottchen wrote: > On 2017/03/31 17:50:13, dpapad wrote: > > Before/after http://imgur.com/a/PbrtI > > lgtm, though I'm curious why the left-right-mark makes it wrap in the first place (http://imgur.com/a/Yj5uX) There is a minimal repro at https://bugs.chromium.org/p/chromium/issues/detail?id=703977#c7 if you want to play with.
The CQ bit was unchecked by dpapad@chromium.org
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
dpapad@chromium.org changed reviewers: + dschuyler@chromium.org
+dschuyler Need a review from a full committer. Thanks.
lgtm
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490993447411620, "parent_rev":
"d0a9f0de257f6fa6597a2dafbb15c2ea5030ca91", "commit_rev":
"cf1cb4ef559d87d9814200e9005437c3643a57cb"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix native languge name wrapping. BUG=703977 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Fix native languge name wrapping. BUG=703977 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2786313006 Cr-Commit-Position: refs/heads/master@{#461230} Committed: https://chromium.googlesource.com/chromium/src/+/cf1cb4ef559d87d9814200e90054... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cf1cb4ef559d87d9814200e90054... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
