Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2786313003: Revert of [heap] Take page lock when scavenging old to new references in Scavenger. (Closed)

Created:
3 years, 8 months ago by Hannes Payer (out of office)
Modified:
3 years, 8 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Take page lock when scavenging old to new references in Scavenger. (patchset #2 id:20001 of https://codereview.chromium.org/2781363002/ ) Reason for revert: This results in a deadlock when the scavenger decides to perform sweeping and re-grabs the same mutex. Original issue's description: > [heap] Take page lock when scavenging old to new references in Scavenger. > > BUG=v8:5807 > > Review-Url: https://codereview.chromium.org/2781363002 > Cr-Commit-Position: refs/heads/master@{#44268} > Committed: https://chromium.googlesource.com/v8/v8/+/4024e6a1bb0b803a5cd16fcd11f39cc305b943c6 TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5807 Review-Url: https://codereview.chromium.org/2786313003 Cr-Commit-Position: refs/heads/master@{#44302} Committed: https://chromium.googlesource.com/v8/v8/+/d6bd3ebaea728d4c6694f22fc5334d1e1b2c1589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M src/heap/heap.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/heap/remembered-set.h View 3 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Hannes Payer (out of office)
Created Revert of [heap] Take page lock when scavenging old to new references in Scavenger.
3 years, 8 months ago (2017-03-31 10:45:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786313003/1
3 years, 8 months ago (2017-03-31 10:45:51 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 10:46:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d6bd3ebaea728d4c6694f22fc5334d1e1b2...

Powered by Google App Engine
This is Rietveld 408576698