Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2786313002: Revert of Add new wired memory metric to memory-infra dumps. (Closed)

Created:
3 years, 8 months ago by stgao
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add new wired memory metric to memory-infra dumps. (patchset #7 id:120001 of https://codereview.chromium.org/2782503002/ ) Reason for revert: New test SystemMetricsTest.LockedBytes failed on Waterfall https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/28540 Original issue's description: > Add new wired memory metric to memory-infra dumps. > > On macOS, wired memory cannot be evicted from physical memory [swapped, purged, > compressed]. We are observing a reproducible instance where Chrome appears to be > responsible for massive amounts of wired memory. It's unclear whether this wired > memory is being allocated by the kernel for resources associated with the task, > or by the task itself. This CL will help us distinguish between these cases. > > BUG=700928 > > Review-Url: https://codereview.chromium.org/2782503002 > Cr-Commit-Position: refs/heads/master@{#460924} > Committed: https://chromium.googlesource.com/chromium/src/+/6a44d440a7e5057f2ad1637f26802e522eeb51ab TBR=primiano@chromium.org,mark@chromium.org,thestig@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700928 Review-Url: https://codereview.chromium.org/2786313002 Cr-Commit-Position: refs/heads/master@{#460972} Committed: https://chromium.googlesource.com/chromium/src/+/b8e248e67b573b9192610580db1382b171fc5f4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -134 lines) Patch
M base/process/process_metrics.h View 1 chunk +2 lines, -5 lines 0 comments Download
M base/process/process_metrics_mac.cc View 5 chunks +35 lines, -85 lines 0 comments Download
M base/process/process_metrics_unittest.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M chrome/browser/task_manager/sampling/task_group_sampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/tracing/common/process_metrics_memory_dump_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
stgao
Created Revert of Add new wired memory metric to memory-infra dumps.
3 years, 8 months ago (2017-03-31 01:06:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786313002/1
3 years, 8 months ago (2017-03-31 01:06:58 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 01:13:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8e248e67b573b9192610580db13...

Powered by Google App Engine
This is Rietveld 408576698