Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2786303002: Add "Supports overlays" information to about:gpu. (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
Reviewers:
Tom Sepez, Zhenyao Mo
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "Supports overlays" information to about:gpu. This depends on a number of factors, including the precise monitor configuration, so make it easy to get from users. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2786303002 Cr-Commit-Position: refs/heads/master@{#461291} Committed: https://chromium.googlesource.com/chromium/src/+/22b40bba05236fd02732e0011c945c222e4238a6

Patch Set 1 #

Total comments: 1

Patch Set 2 : change to AddBool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_info.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_info.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/gpu_info.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/gpu_info_struct_traits.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/ipc/common/gpu_info_struct_traits.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/gpu_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/struct_traits_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_init.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
jbauman
3 years, 8 months ago (2017-03-31 01:26:51 UTC) #8
Zhenyao Mo
lgtm https://codereview.chromium.org/2786303002/diff/1/gpu/config/gpu_info.cc File gpu/config/gpu_info.cc (right): https://codereview.chromium.org/2786303002/diff/1/gpu/config/gpu_info.cc#newcode184 gpu/config/gpu_info.cc:184: enumerator->AddInt("supportsOverlays", supports_overlays); Why not AddBool?
3 years, 8 months ago (2017-03-31 20:02:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786303002/20001
3 years, 8 months ago (2017-03-31 21:47:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/400330)
3 years, 8 months ago (2017-03-31 22:05:04 UTC) #14
jbauman
tsepez@ for security review of adding this flag.
3 years, 8 months ago (2017-03-31 22:18:19 UTC) #15
jbauman
tsepez@ for security review of adding this flag.
3 years, 8 months ago (2017-03-31 22:18:40 UTC) #17
Tom Sepez
lgtm
3 years, 8 months ago (2017-03-31 23:42:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786303002/20001
3 years, 8 months ago (2017-03-31 23:48:44 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 00:53:04 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/22b40bba05236fd02732e0011c94...

Powered by Google App Engine
This is Rietveld 408576698