Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2786263002: Revert of Support for OpenType Font Variations on Windows (Closed)

Created:
3 years, 8 months ago by ortuno
Modified:
3 years, 8 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support for OpenType Font Variations on Windows (patchset #8 id:140001 of https://codereview.chromium.org/2780133002/ ) Reason for revert: Compile failure on linux bot: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/65396 [6410/39636] CXX obj/third_party/pdfium/formfiller/cffl_interactiveformfiller.o FAILED: obj/third_party/pdfium/formfiller/cffl_interactiveformfiller.o /b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/formfiller/cffl_interactiveformfiller.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"298539-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DV8_DEPRECATION_WARNINGS -D_FX_CPU_=_FX_X86_ -DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDFIUM_PRINT_TEXT_WITH_GDI -I../.. -Igen -I../../third_party/pdfium -I../../build/linux/debian_jessie_i386-sysroot/usr/include/freetype2 -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m32 -msse2 -mfpmath=sse -mmmx -momit-leaf-frame-pointer -pthread -mstack-alignment=16 -mstackrealign -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O0 -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../build/linux/debian_jessie_i386-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -c ../../third_party/pdfium/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp -o obj/third_party/pdfium/formfiller/cffl_interactiveformfiller.o In file included from ../../third_party/pdfium/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp:12: In file included from ../../third_party/pdfium/core/fxge/cfx_pathdata.h:14: In file included from ../../third_party/pdfium/core/fxge/cfx_renderdevice.h:12: In file included from ../../third_party/pdfium/core/fxge/cfx_gemodule.h:12: In file included from ../../third_party/pdfium/core/fxge/cfx_fontmgr.h:13: In file included from ../../third_party/pdfium/core/fxge/fx_font.h:17: In file included from ../../third_party/pdfium/core/fxge/fx_freetype.h:11: In file included from ../../build/linux/debian_jessie_i386-sysroot/usr/include/freetype2/freetype.h:33: ../../build/linux/debian_jessie_i386-sysroot/usr/include/freetype2/config/ftconfig.h:453:5: error: 'register' storage class specifier is deprecated and incompatible with C++1z [-Werror,-Wdeprecated-register] register FT_Int32 result; ^~~~~~~~~ 1 error generated. Original issue's description: > Support for OpenType Font Variations on Windows > > Enable support for variable fonts on Windows through using > SkFontMgr_Custom_Empty, a FreeType backed font-blob only SkTypeface > factory (no access to system fonts). We will use a hybrid DirectWrite > and FreeType font stack on Windows for at least as long as most of > Windows versions we support with Chrome still do not have native support > for font variations. > > Thanks to Ben Wagner for the help with enabling and prototyping this. > > BUG=700926 > > Review-Url: https://codereview.chromium.org/2780133002 > Cr-Commit-Position: refs/heads/master@{#460895} > Committed: https://chromium.googlesource.com/chromium/src/+/5265e65e5ea1ae3987c27f76914c9dd9a41506cd TBR=bungeman@chromium.org,bungeman@google.com,eae@chromium.org,kjellander@chromium.org,machenbach@chromium.org,drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700926 Review-Url: https://codereview.chromium.org/2786263002 Cr-Commit-Position: refs/heads/master@{#460909} Committed: https://chromium.googlesource.com/chromium/src/+/b0e1e4e71a556604c95d25562f9447c175e541be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -59 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M build_overrides/pdfium.gni View 1 chunk +2 lines, -3 lines 0 comments Download
M skia/BUILD.gn View 5 chunks +8 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/variable-fonts/variable-box-font-expected.html View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M third_party/freetype/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/freetype/include/freetype-custom-config/ftmodule.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/freetype/include/freetype-custom-config/ftoption.h View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ortuno
Created Revert of Support for OpenType Font Variations on Windows
3 years, 8 months ago (2017-03-30 22:36:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786263002/1
3 years, 8 months ago (2017-03-30 22:37:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b0e1e4e71a556604c95d25562f9447c175e541be
3 years, 8 months ago (2017-03-30 22:39:34 UTC) #6
eae
LGTM (post facto). Thanks for reverting.
3 years, 8 months ago (2017-03-30 22:43:34 UTC) #7
stgao
3 years, 8 months ago (2017-03-30 23:19:55 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2792453002/ by stgao@chromium.org.

The reason for reverting is: The revert didn't help.

https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Builder%20(dbg)....

Powered by Google App Engine
This is Rietveld 408576698