Use Platform.localeName on standalone

Use Platform.localeName on standalone

fixes #136, #12

[zra, 2017-03-30 21:59:16]

zra@google.com changed reviewers:
+ alanknight@google.com

[zra, 2017-03-30 21:59:17]

Sorry, didn't see you had created an issue and assigned yourself. Feel free to
ignore this CL if you've already got something lined up.

[Alan Knight, 2017-03-31 17:24:56]

No, I hadn't started, so that's great.

One comment, but also, the source of truth for intl is internal, so could you do
this as a CL there? Or if you're not familiar with it, I can patch it in.

https://codereview.chromium.org/2786223004/diff/1/lib/intl_standalone.dart
File lib/intl_standalone.dart (right):

https://codereview.chromium.org/2786223004/diff/1/lib/intl_standalone.dart#ne...
lib/intl_standalone.dart:26: Intl.systemLocale =
Intl.canonicalizedLocale(Platform.localeName);
If we're going to be consistent here, we should return the new systemLocale when
we succeed.

And if we can make this synchronous now that will be great, but that's a
significant breaking change, and I'll do that separately and coordinate with a
major version.

[zra, 2017-03-31 17:40:07]

It looks like the sdk sucks intl into third_party/pkg from googlesource, so I am
not familiar with the right place to submit this.

https://codereview.chromium.org/2786223004/diff/1/lib/intl_standalone.dart
File lib/intl_standalone.dart (right):

https://codereview.chromium.org/2786223004/diff/1/lib/intl_standalone.dart#ne...
lib/intl_standalone.dart:26: Intl.systemLocale =
Intl.canonicalizedLocale(Platform.localeName);
On 2017/03/31 17:24:56, Alan Knight wrote:
> If we're going to be consistent here, we should return the new systemLocale
when
> we succeed.
> 
> And if we can make this synchronous now that will be great, but that's a
> significant breaking change, and I'll do that separately and coordinate with a
> major version.

It's returned. You'll see it if you scroll down a bit. Rietveld is just doing a
bad job of displaying the diff.

I'll leave the big breaking change to you ;-)

[Alan Knight, 2017-03-31 17:56:25]

OK. LGTM, but don't submit, I'll patch it in once the localeName fix gets pulled
in. Otherwise we'll get failures because it relies on the API being there.

[zra, 2017-03-31 22:02:55]

Description was changed from

==========
Use Platform.localeName on standalone

fixes #136, #12
==========

to

==========
Use Platform.localeName on standalone

fixes #136, #12
==========