Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2786143004: [bootstrapper] Ensure RegExp constructor has fast properties. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[bootstrapper] Ensure RegExp constructor has fast properties. Currently x instanceof RegExp checks cannot take the fast path, since the RegExp constructor has dictionary properties. To avoid that, just forcibly migrate the RegExp constructor to fast properties again once it's fully setup in the bootstrapper. This yields a 10x improvement for x instanceof RegExp checks. R=yangguo@chromium.org BUG=v8:5902 Review-Url: https://codereview.chromium.org/2786143004 Cr-Commit-Position: refs/heads/master@{#44316} Committed: https://chromium.googlesource.com/v8/v8/+/2de2840f2ec238226504fcf05bac6f01cfd2b53d

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/bootstrapper.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-5902.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
Benedikt Meurer
3 years, 8 months ago (2017-03-31 17:47:18 UTC) #1
Benedikt Meurer
Hey Yang, Here's a quickfix for the RegExp constructor. Maybe we can have a more ...
3 years, 8 months ago (2017-03-31 17:48:35 UTC) #4
Yang
lgtm
3 years, 8 months ago (2017-03-31 18:00:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786143004/20001
3 years, 8 months ago (2017-03-31 18:05:14 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 18:27:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2de2840f2ec238226504fcf05bac6f01cfd...

Powered by Google App Engine
This is Rietveld 408576698