Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2786113003: Change symbol_level for ToT LLD bots (Closed)

Created:
3 years, 8 months ago by Reid Kleckner
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change symbol_level for ToT LLD bots With this change, the release bots use symbol_level=0, which means they don't make PDBs. The debug bots now make full PDBs, which exercises LLD's PDB writing functionality more completely. They'll be red for the foreseeable future, but it gives us something to work towards fixing. R=thakis@chromium.org BUG=706492 Review-Url: https://codereview.chromium.org/2786113003 Cr-Commit-Position: refs/heads/master@{#460886} Committed: https://chromium.googlesource.com/chromium/src/+/95990d668523353e2a4adabff2eeccf207f1f04d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reid Kleckner
3 years, 8 months ago (2017-03-30 18:58:23 UTC) #1
Nico
lgtm stamp But doesn't symbol_level=1 already mean that the compiler writes no PDBs? Is the ...
3 years, 8 months ago (2017-03-30 19:44:17 UTC) #2
Reid Kleckner
On 2017/03/30 19:44:17, Nico (afk until Tue Apr 4) wrote: > lgtm stamp > > ...
3 years, 8 months ago (2017-03-30 19:52:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786113003/1
3 years, 8 months ago (2017-03-30 19:53:26 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:31:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95990d668523353e2a4adabff2ee...

Powered by Google App Engine
This is Rietveld 408576698