Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2786103005: Revert of Fix flaky DownloadTest.FeedbackServiceKeepDownload (Closed)

Created:
3 years, 8 months ago by Jialiu Lin
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix flaky DownloadTest.FeedbackServiceKeepDownload (patchset #2 id:20001 of https://codereview.chromium.org/2778853002/ ) Reason for revert: Should use DownloadTestObserverTerminal instead. Original issue's description: > Fix flaky DownloadTest.FeedbackServiceKeepDownload > > BUG=705224 > > Review-Url: https://codereview.chromium.org/2778853002 > Cr-Commit-Position: refs/heads/master@{#460894} > Committed: https://chromium.googlesource.com/chromium/src/+/0e417c028e62d771638997c4545a359ba93027ec TBR=dtrainor@chromium.org,qinmin@chromium.org,asanka@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705224 Review-Url: https://codereview.chromium.org/2786103005 Cr-Commit-Position: refs/heads/master@{#461143} Committed: https://chromium.googlesource.com/chromium/src/+/cbadcddfb7adac0f013ff2522647f78c19088c5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M chrome/browser/download/download_browsertest.cc View 2 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jialiu Lin
Created Revert of Fix flaky DownloadTest.FeedbackServiceKeepDownload
3 years, 8 months ago (2017-03-31 16:24:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786103005/1
3 years, 8 months ago (2017-03-31 16:25:29 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 16:27:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbadcddfb7adac0f013ff2522647...

Powered by Google App Engine
This is Rietveld 408576698