Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2786063004: Enable pixel video tests (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable pixel video tests All the reference images should exist now. BUG=704389 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2786063004 Cr-Commit-Position: refs/heads/master@{#460871} Committed: https://chromium.googlesource.com/chromium/src/+/c6c435ba5ba3620440a88283237370b8c8d19781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
jbauman
3 years, 8 months ago (2017-03-30 18:57:09 UTC) #7
Ken Russell (switch to Gerrit)
lgtm Did you spot check the images in cloud storage and make sure they look ...
3 years, 8 months ago (2017-03-30 20:43:48 UTC) #8
jbauman
On 2017/03/30 20:43:48, Ken Russell wrote: > lgtm > > Did you spot check the ...
3 years, 8 months ago (2017-03-30 20:47:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786063004/1
3 years, 8 months ago (2017-03-30 20:48:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c6c435ba5ba3620440a88283237370b8c8d19781
3 years, 8 months ago (2017-03-30 20:59:01 UTC) #14
sugoi1
3 years, 8 months ago (2017-03-31 13:30:31 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2784353004/ by sugoi@chromium.org.

The reason for reverting is: Broke "Win10 Release (NVIDIA)" and "Win10 Debug
(NVIDIA)" bots. See:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20(NVIDIA)
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20(NVI....

Powered by Google App Engine
This is Rietveld 408576698