Chromium Code Reviews Chromium Code Reviews
Issue 278603002:
Centering text inside a button set to display flex with justify-content: center is impossible (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html |
| diff --git a/LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html b/LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..7c5addd24c17dcbb741817865ce12a4666b9a357 |
| --- /dev/null |
| +++ b/LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html |
| @@ -0,0 +1,27 @@ |
| +<!doctype html> |
|
ojan
2014/05/23 19:52:39
Nit: We usually use <!DOCTYPE html>.
harpreet.sk
2014/05/24 11:17:22
Done.
|
| +<html> |
| +<head> |
|
ojan
2014/05/23 19:52:39
Nit: we usually leave out the html, head and body
harpreet.sk
2014/05/24 11:17:22
Done.
|
| +<style> |
| +button { |
| + border: 0; |
| + padding: 0; |
| + background-color: white; |
| + font-family: sans-serif; |
| + font-size: initial; |
| + width: 300px; |
| +} |
| + |
| +.flex { |
| + display: flex; |
| +} |
| + |
| +.flex-center { |
| + justify-content: center; |
| +} |
| +</style> |
| +</head> |
| +<body> |
| +<h4>Test for BUG=344733: Centering text inside a button set to display flex and justify-content: center is impossible</h4> |
|
ojan
2014/05/23 19:52:39
Nit: If you're going to include a bug, use a URL c
harpreet.sk
2014/05/24 11:17:22
Done.
|
| +<button class="flex flex-center">text with justify-content: center</button> |
|
ojan
2014/05/23 19:52:39
Nit: I'd drop the classnames entirely. You can mer
harpreet.sk
2014/05/24 11:17:22
Done.
|
| +</body> |
| +</html> |
