LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html - Issue 278603002: Centering text inside a button set to display flex with justify-content: center is impossible

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html

Issue 278603002: Centering text inside a button set to display flex with justify-content: center is impossible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addresses the changes asked in patch set 6 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>
	ojan 2014/05/23 19:52:39 Nit: We usually use <!DOCTYPE html>. Nit: We usually use <!DOCTYPE html>. harpreet.sk 2014/05/24 11:17:22 Done. Show quoted text On 2014/05/23 19:52:39, ojan wrote: > Nit: We usually use <!DOCTYPE html>. Done.
	2 <html>

	3 <head>
	ojan 2014/05/23 19:52:39 Nit: we usually leave out the html, head and body Nit: we usually leave out the html, head and body elements if the test doesn't explicitly require them. harpreet.sk 2014/05/24 11:17:22 Done. Show quoted text On 2014/05/23 19:52:39, ojan wrote: > Nit: we usually leave out the html, head and body elements if the test doesn't > explicitly require them. Done.
	4 <style>

	5 button {

	6 border: 0;

	7 padding: 0;

	8 background-color: white;

	9 font-family: sans-serif;

	10 font-size: initial;

	11 width: 300px;

	12 }

	13

	14 .flex {

	15 display: flex;

	16 }

	17

	18 .flex-center {

	19 justify-content: center;

	20 }

	21 </style>

	22 </head>

	23 <body>

	24 <h4>Test for BUG=344733: Centering text inside a button set to display flex and justify-content: center is impossible</h4>
	ojan 2014/05/23 19:52:39 Nit: If you're going to include a bug, use a URL c Nit: If you're going to include a bug, use a URL crbug.com/344733. It makes it more friendly to people who are working on this. That said, I'd just leave out the bug information. That's contained in the history (i.e. it's in the change description for this patch, which people can easily get to by looking at the log for this file). harpreet.sk 2014/05/24 11:17:22 Done. Show quoted text On 2014/05/23 19:52:39, ojan wrote: > Nit: If you're going to include a bug, use a URL crbug.com/344733. It makes it > more friendly to people who are working on this. > > That said, I'd just leave out the bug information. That's contained in the > history (i.e. it's in the change description for this patch, which people can > easily get to by looking at the log for this file). Done.
	25 <button class="flex flex-center">text with justify-content: center</button>
	ojan 2014/05/23 19:52:39 Nit: I'd drop the classnames entirely. You can mer Nit: I'd drop the classnames entirely. You can merge all the styles into the single button rule. It makes it so that there's slightly less going on in the test case for someone reading it to figure out. harpreet.sk 2014/05/24 11:17:22 Done. Show quoted text On 2014/05/23 19:52:39, ojan wrote: > Nit: I'd drop the classnames entirely. You can merge all the styles into the > single button rule. It makes it so that there's slightly less going on in the > test case for someone reading it to figure out. Done.
	26 </body>

	27 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/button-set-display-flex-justifyContent-center-expected.html » ('j') | no next file with comments »