Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2786003003: Revert of Upload the test results html file to google bucket. (Closed)

Created:
3 years, 8 months ago by BigBossZhiling
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upload the test results html file to google bucket. (patchset #9 id:160001 of https://codereview.chromium.org/2777353002/ ) Reason for revert: Causing error in build bot Original issue's description: > Upload the test results html file to google bucket. > > Previously we print the test results html to stdout. In this cl, we > upload the test results html to google bucket and print the link to the > file instead. > > Sample link would be > 'https://storage.googleapis.com/chromium-result-details/html/test_name/builder_name_builder_number_2017_03_27_T15_22_47.html'. > > BUG= > > Review-Url: https://codereview.chromium.org/2777353002 > Cr-Commit-Position: refs/heads/master@{#460827} > Committed: https://chromium.googlesource.com/chromium/src/+/0046d99e3911d416d0b5cb6f6f0191317bf41711 TBR=mikecase@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2786003003 Cr-Commit-Position: refs/heads/master@{#460853} Committed: https://chromium.googlesource.com/chromium/src/+/9c03a0c535466dd59dd578e1d180863dbe3f1fd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -45 lines) Patch
M build/android/pylib/results/presentation/template/main.html View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/results/presentation/test_results_presentation.py View 4 chunks +10 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
BigBossZhiling
Created Revert of Upload the test results html file to google bucket.
3 years, 8 months ago (2017-03-30 19:31:24 UTC) #2
BigBossZhiling
3 years, 8 months ago (2017-03-30 19:31:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786003003/1
3 years, 8 months ago (2017-03-30 19:32:38 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-30 19:32:40 UTC) #6
jbudorick
lgtm
3 years, 8 months ago (2017-03-30 19:33:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786003003/1
3 years, 8 months ago (2017-03-30 19:38:26 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 19:42:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c03a0c535466dd59dd578e1d180...

Powered by Google App Engine
This is Rietveld 408576698