Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2786003002: DevTools: Allow tabbing in and out of TextPrompt (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Allow tabbing in and out of TextPrompt TextPrompt was handling tab events even if there was no autocomplete. BUG=706699, 668161 Review-Url: https://codereview.chromium.org/2786003002 Cr-Commit-Position: refs/heads/master@{#461052} Committed: https://chromium.googlesource.com/chromium/src/+/93cf8ced501ad85664fa80e69610621b69b6dd09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
einbinder
ptal
3 years, 8 months ago (2017-03-30 06:24:57 UTC) #2
pfeldman
lgtm
3 years, 8 months ago (2017-03-31 00:01:06 UTC) #3
pfeldman
(i am sure something will break though)
3 years, 8 months ago (2017-03-31 00:01:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786003002/1
3 years, 8 months ago (2017-03-31 00:48:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/339968)
3 years, 8 months ago (2017-03-31 03:20:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786003002/1
3 years, 8 months ago (2017-03-31 03:57:43 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 05:53:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/93cf8ced501ad85664fa80e69610...

Powered by Google App Engine
This is Rietveld 408576698