DevTools: Allow ToolbarMenuButtons to be trigged via keyboard

DevTools: Allow ToolbarMenuButtons to be trigged via keyboard

ToolbarMenuButtons were checking for a mousedown event before a click event.
Pressing enter when the button is focused only sends a click event.

BUG=706699
Review-Url: https://codereview.chromium.org/2785993002
Cr-Commit-Position: refs/heads/master@{#461376}
Committed: https://chromium.googlesource.com/chromium/src/+/c86b1f8a0db09846e20cf28a43cd4ead737e8c3c

[einbinder, 2017-03-30 06:15:31]

Description was changed from

==========
DevTools: Allow ToolbarMenuButtons to be trigged via keyboard

BUG=706699
==========

to

==========
DevTools: Allow ToolbarMenuButtons to be trigged via keyboard

ToolbarMenuButtons were checking for a mousedown event before a click event.
Pressing enter when the button is focused only sends a click event.

BUG=706699
==========

[einbinder, 2017-03-30 06:15:41]

einbinder@chromium.org changed reviewers:
+ pfeldman@chromium.org

[einbinder, 2017-03-30 06:15:41]

ptal

[pfeldman, 2017-03-31 00:02:05]

lgtm % nit

https://codereview.chromium.org/2785993002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (left):

https://codereview.chromium.org/2785993002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:748: if
(!this._triggerTimeout)
What if there wasn't? At least clearTimeout conditionally?

[einbinder, 2017-04-03 05:21:26]

https://codereview.chromium.org/2785993002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (left):

https://codereview.chromium.org/2785993002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:748: if
(!this._triggerTimeout)
On 2017/03/31 at 00:02:05, pfeldman wrote:
> What if there wasn't? At least clearTimeout conditionally?

Done.

[einbinder, 2017-04-03 05:21:30]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-04-03 05:21:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2785993002/#ps20001
(title: "conditional clear")

[commit-bot: I haz the power, 2017-04-03 05:21:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 06:36:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491196890405600,
"parent_rev": "c4065e636ba2ba710635803d500f63c67a3a2ca0", "commit_rev":
"c86b1f8a0db09846e20cf28a43cd4ead737e8c3c"}

[commit-bot: I haz the power, 2017-04-03 06:38:11]

Description was changed from

==========
DevTools: Allow ToolbarMenuButtons to be trigged via keyboard

ToolbarMenuButtons were checking for a mousedown event before a click event.
Pressing enter when the button is focused only sends a click event.

BUG=706699
==========

to

==========
DevTools: Allow ToolbarMenuButtons to be trigged via keyboard

ToolbarMenuButtons were checking for a mousedown event before a click event.
Pressing enter when the button is focused only sends a click event.

BUG=706699

Review-Url: https://codereview.chromium.org/2785993002
Cr-Commit-Position: refs/heads/master@{#461376}
Committed:
https://chromium.googlesource.com/chromium/src/+/c86b1f8a0db09846e20cf28a43cd...
==========

[commit-bot: I haz the power, 2017-04-03 06:38:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c86b1f8a0db09846e20cf28a43cd...