Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

Issue 2785983002: [ES6 modules] ScriptModule::instantiate with resolveModule cb and error handling (Closed)
Patch Set: add_tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
index fc51232d7f5d635423021db752bd6d01bb9ff217..60018945da94281bab39a20f026b7da83a2b5950 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
@@ -26,7 +26,8 @@ class CORE_EXPORT ScriptModule final {
ScriptModule(const ScriptModule& module) : m_module(module.m_module) {}
~ScriptModule();
- bool instantiate(ScriptState*);
+ // Returns exception, if any.
+ ScriptValue instantiate(ScriptState*);
void evaluate(ScriptState*);
bool isNull() const { return m_module->isEmpty(); }
@@ -34,6 +35,11 @@ class CORE_EXPORT ScriptModule final {
private:
ScriptModule(v8::Isolate*, v8::Local<v8::Module>);
+ static v8::MaybeLocal<v8::Module> resolveModuleCallback(
+ v8::Local<v8::Context>,
+ v8::Local<v8::String> specifier,
+ v8::Local<v8::Module> referrer);
+
RefPtr<SharedPersistent<v8::Module>> m_module;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698