Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

Issue 2785983002: [ES6 modules] ScriptModule::instantiate with resolveModule cb and error handling (Closed)
Patch Set: add_tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ScriptModule_h 5 #ifndef ScriptModule_h
6 #define ScriptModule_h 6 #define ScriptModule_h
7 7
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/SharedPersistent.h" 9 #include "bindings/core/v8/SharedPersistent.h"
10 #include "core/CoreExport.h" 10 #include "core/CoreExport.h"
11 #include "v8/include/v8.h" 11 #include "v8/include/v8.h"
12 #include "wtf/Allocator.h" 12 #include "wtf/Allocator.h"
13 #include "wtf/text/WTFString.h" 13 #include "wtf/text/WTFString.h"
14 14
15 namespace blink { 15 namespace blink {
16 16
17 class CORE_EXPORT ScriptModule final { 17 class CORE_EXPORT ScriptModule final {
18 DISALLOW_NEW_EXCEPT_PLACEMENT_NEW(); 18 DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
19 19
20 public: 20 public:
21 static ScriptModule compile(v8::Isolate*, 21 static ScriptModule compile(v8::Isolate*,
22 const String& source, 22 const String& source,
23 const String& fileName); 23 const String& fileName);
24 24
25 ScriptModule() {} 25 ScriptModule() {}
26 ScriptModule(const ScriptModule& module) : m_module(module.m_module) {} 26 ScriptModule(const ScriptModule& module) : m_module(module.m_module) {}
27 ~ScriptModule(); 27 ~ScriptModule();
28 28
29 bool instantiate(ScriptState*); 29 // Returns exception, if any.
30 ScriptValue instantiate(ScriptState*);
30 void evaluate(ScriptState*); 31 void evaluate(ScriptState*);
31 32
32 bool isNull() const { return m_module->isEmpty(); } 33 bool isNull() const { return m_module->isEmpty(); }
33 34
34 private: 35 private:
35 ScriptModule(v8::Isolate*, v8::Local<v8::Module>); 36 ScriptModule(v8::Isolate*, v8::Local<v8::Module>);
36 37
38 static v8::MaybeLocal<v8::Module> resolveModuleCallback(
39 v8::Local<v8::Context>,
40 v8::Local<v8::String> specifier,
41 v8::Local<v8::Module> referrer);
42
37 RefPtr<SharedPersistent<v8::Module>> m_module; 43 RefPtr<SharedPersistent<v8::Module>> m_module;
38 }; 44 };
39 45
40 } // namespace blink 46 } // namespace blink
41 47
42 #endif // ScriptModule_h 48 #endif // ScriptModule_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698