third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp - Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)

Patch Set: work for comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

index 42cd4c8af52b6fa3dbf4a17735dc7675e53f3817..0ae6702999d2241f808356f254abba635b0183fc 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -232,8 +232,8 @@ static void promiseRejectHandler(v8::PromiseRejectMessage data,

// DOMException).

ASSERT(exception->IsObject());

auto privateError = V8PrivateProperty::getDOMExceptionError(isolate);

- v8::Local<v8::Value> error = privateError.getOrUndefined(

- scriptState->context(), exception.As<v8::Object>());

+ v8::Local<v8::Value> error =

+ privateError.getOrUndefined(exception.As<v8::Object>());

if (!error->IsUndefined())

exception = error;

}