Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)
Patch Set: work for comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
index 9f075e0e32c9b4bbf23ffa55ac034d6e1df34140..2a3b521c336627e8708570a7d27702aa600a85f2 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
@@ -67,8 +67,7 @@ v8::Local<v8::Value> V8ErrorHandler::callListenerFunction(
if (!jsEvent->ToObject(scriptState->context()).ToLocal(&eventObject))
return v8::Null(isolate());
auto privateError = V8PrivateProperty::getErrorEventError(isolate());
- v8::Local<v8::Value> error =
- privateError.getOrUndefined(scriptState->context(), eventObject);
+ v8::Local<v8::Value> error = privateError.getOrUndefined(eventObject);
if (error->IsUndefined())
error = v8::Null(isolate());
@@ -110,7 +109,7 @@ void V8ErrorHandler::storeExceptionOnErrorEventWrapper(
DCHECK(wrappedEvent->IsObject());
auto privateError =
V8PrivateProperty::getErrorEventError(scriptState->isolate());
- privateError.set(scriptState->context(), wrappedEvent.As<v8::Object>(), data);
+ privateError.set(wrappedEvent.As<v8::Object>(), data);
}
// static
@@ -126,8 +125,8 @@ v8::Local<v8::Value> V8ErrorHandler::loadExceptionFromErrorEventWrapper(
DCHECK(wrappedEvent->IsObject());
auto privateError =
V8PrivateProperty::getErrorEventError(scriptState->isolate());
- v8::Local<v8::Value> error = privateError.getOrUndefined(
- scriptState->context(), wrappedEvent.As<v8::Object>());
+ v8::Local<v8::Value> error =
+ privateError.getOrUndefined(wrappedEvent.As<v8::Object>());
if (error->IsUndefined())
return v8::Local<v8::Value>();
return error;

Powered by Google App Engine
This is Rietveld 408576698