[subresource_filter] Clean up special cases in TabSpecificContentSettings

[subresource_filter] Clean up special cases in TabSpecificContentSettings

Now that Subresource Filter has a content setting, use that instead of
ad-hoc state in the TabSpecificContentSettings.

This also fixes a bug where the omnibox is not updated properly when
the first disallowed load occurs. TabSpecificContentSettings has special
logic in OnContentBlockedWithDetail that the subresource filter code
lacked.

BUG=707026
Review-Url: https://codereview.chromium.org/2785923003
Cr-Commit-Position: refs/heads/master@{#461169}
Committed: https://chromium.googlesource.com/chromium/src/+/81f7c216e1ebbcda921597130789d349dae9f8bf

[Charlie Harrison, 2017-03-30 21:20:38]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 21:22:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-03-30 21:27:03]

Description was changed from

==========
[subresource_filter] Clean up TabSpecificContentSettings

Now that Subresource Filter has a content setting, use that instead of
ad-hoc state in the TabSpecificContentSettings.

This also fixes a bug where the omnibox is not updated properly when
the first disallowed load occurs.

BUG=TODO
==========

to

==========
[subresource_filter] Clean up TabSpecificContentSettings

Now that Subresource Filter has a content setting, use that instead of
ad-hoc state in the TabSpecificContentSettings.

This also fixes a bug where the omnibox is not updated properly when
the first disallowed load occurs.

BUG=707026
==========

[Charlie Harrison, 2017-03-30 21:43:37]

Description was changed from

==========
[subresource_filter] Clean up TabSpecificContentSettings

Now that Subresource Filter has a content setting, use that instead of
ad-hoc state in the TabSpecificContentSettings.

This also fixes a bug where the omnibox is not updated properly when
the first disallowed load occurs.

BUG=707026
==========

to

==========
[subresource_filter] Clean up special cases in TabSpecificContentSettings

Now that Subresource Filter has a content setting, use that instead of
ad-hoc state in the TabSpecificContentSettings.

This also fixes a bug where the omnibox is not updated properly when
the first disallowed load occurs. TabSpecificContentSettings has special
logic in OnContentBlockedWithDetail that the subresource filter code
lacked.

BUG=707026
==========

[Charlie Harrison, 2017-03-30 21:48:04]

csharrison@chromium.org changed reviewers:
+ bauerb@chromium.org, pkalinnikov@chromium.org

[Charlie Harrison, 2017-03-30 21:48:04]

bauerb: PTAL at this cleanup? This is now possible since SubresourceFilter has a
content setting. This setting is currently unused for policy decisions, but we
can still use it for the blockage indicator.

pkalinnikov: PTAL at subresource_filter bits (fairly straightforward)

[pkalinnikov, 2017-03-31 13:16:56]

subresource_filter LGTM.

[Bernhard Bauer, 2017-03-31 15:38:33]

lgtm

[Charlie Harrison, 2017-03-31 15:40:15]

Thanks, folks!

[Charlie Harrison, 2017-03-31 15:42:15]

Oh, this doesn't have to be a dependent CL anymore. Landing as-is.

[Charlie Harrison, 2017-03-31 15:42:22]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2017-03-31 15:42:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
pkalinnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2785923003/#ps40001
(title: "remove dependent CL")

[commit-bot: I haz the power, 2017-03-31 15:43:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 17:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:13:24]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Charlie Harrison, 2017-03-31 17:16:40]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:17:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 17:57:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490980600568880,
"parent_rev": "2cffb0d3f6c29108c934e5eff64483ba264191d1", "commit_rev":
"81f7c216e1ebbcda921597130789d349dae9f8bf"}

[commit-bot: I haz the power, 2017-03-31 17:57:50]

Description was changed from

==========
[subresource_filter] Clean up special cases in TabSpecificContentSettings

Now that Subresource Filter has a content setting, use that instead of
ad-hoc state in the TabSpecificContentSettings.

This also fixes a bug where the omnibox is not updated properly when
the first disallowed load occurs. TabSpecificContentSettings has special
logic in OnContentBlockedWithDetail that the subresource filter code
lacked.

BUG=707026
==========

to

==========
[subresource_filter] Clean up special cases in TabSpecificContentSettings

Now that Subresource Filter has a content setting, use that instead of
ad-hoc state in the TabSpecificContentSettings.

This also fixes a bug where the omnibox is not updated properly when
the first disallowed load occurs. TabSpecificContentSettings has special
logic in OnContentBlockedWithDetail that the subresource filter code
lacked.

BUG=707026

Review-Url: https://codereview.chromium.org/2785923003
Cr-Commit-Position: refs/heads/master@{#461169}
Committed:
https://chromium.googlesource.com/chromium/src/+/81f7c216e1ebbcda921597130789...
==========

[commit-bot: I haz the power, 2017-03-31 17:57:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/81f7c216e1ebbcda921597130789...