Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2785913003: Add an Origin Trial for Navigator.getInstalledRelatedApps. (Closed)

Created:
3 years, 8 months ago by Matt Giuca
Modified:
3 years, 8 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chasej+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, haraken, iclelland+watch_chromuim.org, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an Origin Trial for Navigator.getInstalledRelatedApps. BUG=587623 Review-Url: https://codereview.chromium.org/2785913003 Cr-Commit-Position: refs/heads/master@{#461360} Committed: https://chromium.googlesource.com/chromium/src/+/1970247d68492c3fa208468e34aab2d7803c192b

Patch Set 1 #

Patch Set 2 : Fix tests and make non-Android-specific. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/installedapp-origin-trial-interfaces.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/installedapp-origin-trial-interfaces-script-added.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/installedapp-origin-trial-interfaces-script-added-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/installedapp-origin-trial-interfaces-script-added-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/RelatedApplication.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Matt Giuca
Hi Elliott. Please have a look at this change to enable origin trial. Intent to ...
3 years, 8 months ago (2017-03-31 05:33:49 UTC) #4
esprehn
Lgtm though the runtime flag and origin trial names are confusing with stuff like web ...
3 years, 8 months ago (2017-03-31 06:00:55 UTC) #5
Matt Giuca
On 2017/03/31 06:00:55, esprehn wrote: > Lgtm though the runtime flag and origin trial names ...
3 years, 8 months ago (2017-04-03 00:21:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785913003/20001
3 years, 8 months ago (2017-04-03 00:45:43 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 02:11:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1970247d68492c3fa208468e34aa...

Powered by Google App Engine
This is Rietveld 408576698