Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)
Patch Set: Address various comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h
diff --git a/ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h b/ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h
index c2b5f34dea080e34c1cc81a1fe513a95feb1d7c2..8f8395704bf1e27ea3f2377b81c93297f6440588 100644
--- a/ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h
+++ b/ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h
@@ -7,8 +7,21 @@
#import <UIKit/UIKit.h>
+#import "ios/clean/chrome/browser/ui/ntp/new_tab_page_consumer.h"
+
+@protocol NTPCommands;
+
// View controller that displays a new tab page.
-@interface NTPViewController : UIViewController
+@interface NTPViewController : UIViewController<NTPConsumer>
+// The dispatcher for this view controller
lpromero 2017/04/06 13:01:06 Add more new lines to this interface.
justincohen 2017/04/06 18:25:10 Done.
+@property(nonatomic, weak) id<NTPCommands> dispatcher;
+
+// Add a Chrome Home panel.
lpromero 2017/04/06 13:01:06 *Adds, here and below.
justincohen 2017/04/06 18:25:11 Done.
+- (void)addHomePanelViewController:(UIViewController*)controller;
+// Add a bookmarks panel on iPad or present a bookmarks panel on iPhone.
+- (void)addBookmarksViewController:(UIViewController*)controller;
+// Add a open tabs panel on iPad or present a bookmarks panel on iPhone.
+- (void)addOpenTabsViewController:(UIViewController*)controller;
lpromero 2017/04/06 13:01:06 Please add unittests for these methods. Or a Showc
justincohen 2017/04/06 18:25:10 Added stub unittests for now.
@end
#endif // IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698