ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h - Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)

Patch Set: Address various comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/ntp/new_tab_page_mediator.mm ('K') | « ios/clean/chrome/browser/ui/ntp/new_tab_page_mediator.mm ('k') | ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.mm » ('j') | ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_

6 #define IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_	6 #define IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_

7	7

8 #import <UIKit/UIKit.h>	8 #import <UIKit/UIKit.h>

9	9

	10 #import "ios/clean/chrome/browser/ui/ntp/new_tab_page_consumer.h"

	11

	12 @protocol NTPCommands;

	13

10 // View controller that displays a new tab page.	14 // View controller that displays a new tab page.

11 @interface NTPViewController : UIViewController	15 @interface NTPViewController : UIViewController<NTPConsumer>

	16 // The dispatcher for this view controller
	lpromero 2017/04/06 13:01:06 Add more new lines to this interface. Add more new lines to this interface. justincohen 2017/04/06 18:25:10 Done. Show quoted text On 2017/04/06 13:01:06, lpromero wrote: > Add more new lines to this interface. Done.
	17 @property(nonatomic, weak) id<NTPCommands> dispatcher;

	18

	19 // Add a Chrome Home panel.
	lpromero 2017/04/06 13:01:06 Adds, here and below. Adds, here and below. justincohen 2017/04/06 18:25:11 Done. Show quoted text On 2017/04/06 13:01:06, lpromero wrote: > *Adds, here and below. Done.
	20 - (void)addHomePanelViewController:(UIViewController*)controller;

	21 // Add a bookmarks panel on iPad or present a bookmarks panel on iPhone.

	22 - (void)addBookmarksViewController:(UIViewController*)controller;

	23 // Add a open tabs panel on iPad or present a bookmarks panel on iPhone.

	24 - (void)addOpenTabsViewController:(UIViewController*)controller;
	lpromero 2017/04/06 13:01:06 Please add unittests for these methods. Or a Showc Please add unittests for these methods. Or a Showcase EarlGrey test. justincohen 2017/04/06 18:25:10 Added stub unittests for now. Show quoted text On 2017/04/06 13:01:06, lpromero wrote: > Please add unittests for these methods. Or a Showcase EarlGrey test. Added stub unittests for now.
12 @end	25 @end

13	26

14 #endif // IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_	27 #endif // IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_

OLD	NEW