Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: ios/clean/chrome/browser/ui/commands/ntp_commands.h

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)
Patch Set: Address various comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/commands/ntp_commands.h
diff --git a/ios/clean/chrome/browser/ui/commands/ntp_commands.h b/ios/clean/chrome/browser/ui/commands/ntp_commands.h
new file mode 100644
index 0000000000000000000000000000000000000000..20a1f7859536bd5da37c51551fa4fa3aec5960b0
--- /dev/null
+++ b/ios/clean/chrome/browser/ui/commands/ntp_commands.h
@@ -0,0 +1,19 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_NTP_COMMANDS_H_
+#define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_NTP_COMMANDS_H_
+
+// Command protocol for commands relating to the Settings UI.
lpromero 2017/04/06 13:01:04 s/Settings/NTP
rohitrao (ping after 24h) 2017/04/06 13:08:13 Update comment to not reference Settings.
justincohen 2017/04/06 18:25:09 copy pasta is delicious.
justincohen 2017/04/06 18:25:09 oops, thanks.
+// (Commands are for communicating into or within the coordinator layer).
+@protocol NTPCommands
+// Start a Chrome Home panel.
lpromero 2017/04/06 13:01:04 s/Start/Starts here and below.
justincohen 2017/04/06 18:25:09 Changed to display.
+- (void)showNTPHomePanel;
+// Start a bookmarks panel on iPad or present a bookmarks panel on iPhone.
lpromero 2017/04/06 13:01:04 What does Start mean in this context? Start from c
lpromero 2017/04/06 13:01:04 s/present/presents
justincohen 2017/04/06 18:25:09 Changed wording to display with better explanation
justincohen 2017/04/06 18:25:09 Acknowledged.
+- (void)showNTPBookmarksPanel;
+// Start a open tabs panel on iPad or present a bookmarks panel on iPhone.
+- (void)showNTPOpenTabsPanel;
+@end
+
+#endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_NTP_COMMANDS_H_

Powered by Google App Engine
This is Rietveld 408576698