ios/clean/chrome/browser/ui/commands/ntp_commands.h - Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/commands/ntp_commands.h

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)

Patch Set: Address various comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.mm ('K') | « ios/clean/chrome/browser/ui/commands/BUILD.gn ('k') | ios/clean/chrome/browser/ui/ntp/BUILD.gn » ('j') | ios/clean/chrome/browser/ui/ntp/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_NTP_COMMANDS_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_NTP_COMMANDS_H_

	7

	8 // Command protocol for commands relating to the Settings UI.
	lpromero 2017/04/06 13:01:04 s/Settings/NTP s/Settings/NTP rohitrao (ping after 24h) 2017/04/06 13:08:13 Update comment to not reference Settings. Update comment to not reference Settings. justincohen 2017/04/06 18:25:09 copy pasta is delicious. Show quoted text On 2017/04/06 13:08:13, rohitrao wrote: > Update comment to not reference Settings. copy pasta is delicious. justincohen 2017/04/06 18:25:09 oops, thanks. Show quoted text On 2017/04/06 13:01:04, lpromero wrote: > s/Settings/NTP oops, thanks.
	9 // (Commands are for communicating into or within the coordinator layer).

	10 @protocol NTPCommands

	11 // Start a Chrome Home panel.
	lpromero 2017/04/06 13:01:04 s/Start/Starts here and below. s/Start/Starts here and below. justincohen 2017/04/06 18:25:09 Changed to display. Show quoted text On 2017/04/06 13:01:04, lpromero wrote: > s/Start/Starts here and below. Changed to display.
	12 - (void)showNTPHomePanel;

	13 // Start a bookmarks panel on iPad or present a bookmarks panel on iPhone.
	lpromero 2017/04/06 13:01:04 What does Start mean in this context? Start from c What does Start mean in this context? Start from coordinators? Presentation is also a kind of coordinator start. lpromero 2017/04/06 13:01:04 s/present/presents s/present/presents justincohen 2017/04/06 18:25:09 Changed wording to display with better explanation Show quoted text On 2017/04/06 13:01:04, lpromero wrote: > What does Start mean in this context? Start from coordinators? Presentation is > also a kind of coordinator start. Changed wording to display with better explanation justincohen 2017/04/06 18:25:09 Acknowledged. Show quoted text On 2017/04/06 13:01:04, lpromero wrote: > s/present/presents Acknowledged.
	14 - (void)showNTPBookmarksPanel;

	15 // Start a open tabs panel on iPad or present a bookmarks panel on iPhone.

	16 - (void)showNTPOpenTabsPanel;

	17 @end

	18

	19 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_NTP_COMMANDS_H_

OLD	NEW