Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/network/proxy/ui_proxy_config.h

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: Fix compilation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/proxy/proxy_config_service_impl.cc ('k') | chromeos/network/proxy/ui_proxy_config.cc » ('j') | components/policy/core/browser/proxy_policy_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/proxy/ui_proxy_config.h
diff --git a/chromeos/network/proxy/ui_proxy_config.h b/chromeos/network/proxy/ui_proxy_config.h
index 4338a39b67bc7b081b16e9e705c0b63e597a12f1..cf0553690fb2d4055944a455f3f67434cc21206a 100644
--- a/chromeos/network/proxy/ui_proxy_config.h
+++ b/chromeos/network/proxy/ui_proxy_config.h
@@ -5,6 +5,7 @@
#ifndef CHROMEOS_NETWORK_PROXY_UI_PROXY_CONFIG_H_
#define CHROMEOS_NETWORK_PROXY_UI_PROXY_CONFIG_H_
+#include <memory>
#include <string>
#include "chromeos/chromeos_export.h"
@@ -74,7 +75,7 @@ struct CHROMEOS_EXPORT UIProxyConfig {
// Converts |this| to Dictionary of ProxyConfigDictionary format (which
// is the same format used by prefs).
- base::DictionaryValue* ToPrefProxyConfig() const;
+ std::unique_ptr<base::DictionaryValue> ToPrefProxyConfig() const;
// Map |scheme| (one of "http", "https", "ftp" or "socks") to the correct
// ManualProxy. Returns NULL if scheme is invalid.
« no previous file with comments | « chromeos/network/proxy/proxy_config_service_impl.cc ('k') | chromeos/network/proxy/ui_proxy_config.cc » ('j') | components/policy/core/browser/proxy_policy_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698