chromeos/network/proxy/proxy_config_service_impl.cc - Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/proxy/proxy_config_service_impl.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)

Patch Set: Fix compilation Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/proxy/proxy_config_service_impl.cc

diff --git a/chromeos/network/proxy/proxy_config_service_impl.cc b/chromeos/network/proxy/proxy_config_service_impl.cc

index 3536e803524e7dbe5202a773946c5cb1ea32cf51..e348f58565ad304b03279f27ed1344e978b4f293 100644

--- a/chromeos/network/proxy/proxy_config_service_impl.cc

+++ b/chromeos/network/proxy/proxy_config_service_impl.cc

@@ -193,7 +193,8 @@ ProxyConfigServiceImpl::GetActiveProxyConfigDictionary(

bool value_exists = pref->GetValue()->GetAsDictionary(&proxy_config_value);

DCHECK(value_exists);

- return base::MakeUnique<ProxyConfigDictionary>(proxy_config_value);

+ return base::MakeUnique<ProxyConfigDictionary>(

+ proxy_config_value->CreateDeepCopy());

}

const NetworkState* network =