chromeos/network/onc/onc_utils.h - Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_utils.h

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)

Patch Set: Fix compilation Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_utils.h

diff --git a/chromeos/network/onc/onc_utils.h b/chromeos/network/onc/onc_utils.h

index 189f4e9ffc1c788b52d7d31b8c39a7854c8c345e..2655c366e10bef99617e2d1521e8fc0d4c44f18d 100644

--- a/chromeos/network/onc/onc_utils.h

+++ b/chromeos/network/onc/onc_utils.h

@@ -164,7 +164,7 @@ ConvertOncProxySettingsToProxyConfig(

// (see proxy_config_dictionary.h) to an ONC ProxySettings dictionary.

CHROMEOS_EXPORT std::unique_ptr<base::DictionaryValue>

ConvertProxyConfigToOncProxySettings(

- const base::DictionaryValue& proxy_config_value);

+ std::unique_ptr<base::DictionaryValue> proxy_config_value);

// Replaces string placeholders in |network_configs|, which must be a list of

// ONC NetworkConfigurations. Currently only user name placeholders are