Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chromeos/network/onc/onc_translator_shill_to_onc.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: Fix compilation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_translator_shill_to_onc.cc
diff --git a/chromeos/network/onc/onc_translator_shill_to_onc.cc b/chromeos/network/onc/onc_translator_shill_to_onc.cc
index ce403666456eb6d7667b58ac74806aa2528007cb..eacb2c3763fa6c645dedd9b5c206079c34521371 100644
--- a/chromeos/network/onc/onc_translator_shill_to_onc.cc
+++ b/chromeos/network/onc/onc_translator_shill_to_onc.cc
@@ -583,7 +583,7 @@ void ShillToONCTranslator::TranslateNetworkWithState() {
ReadDictionaryFromJson(proxy_config_str));
if (proxy_config_value) {
std::unique_ptr<base::DictionaryValue> proxy_settings =
- ConvertProxyConfigToOncProxySettings(*proxy_config_value);
+ ConvertProxyConfigToOncProxySettings(std::move(proxy_config_value));
if (proxy_settings) {
onc_object_->SetWithoutPathExpansion(
::onc::network_config::kProxySettings, proxy_settings.release());

Powered by Google App Engine
This is Rietveld 408576698