Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: Fix compilation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
diff --git a/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
index bd813c5f9ca08f11ab4981c73d06e530d3818226..e6019136b19d7698d7435399d31dd4b222e09277 100644
--- a/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
+++ b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
@@ -324,19 +324,19 @@ class ProxyConfigServiceImplTest : public testing::Test {
std::unique_ptr<base::DictionaryValue> new_config;
switch (input.mode) {
case MK_MODE(DIRECT):
- new_config.reset(ProxyConfigDictionary::CreateDirect());
+ new_config = ProxyConfigDictionary::CreateDirect();
break;
case MK_MODE(AUTO_DETECT):
- new_config.reset(ProxyConfigDictionary::CreateAutoDetect());
+ new_config = ProxyConfigDictionary::CreateAutoDetect();
break;
case MK_MODE(PAC_SCRIPT):
- new_config.reset(
- ProxyConfigDictionary::CreatePacScript(input.pac_url, false));
+ new_config =
+ ProxyConfigDictionary::CreatePacScript(input.pac_url, false);
break;
case MK_MODE(SINGLE_PROXY):
case MK_MODE(PROXY_PER_SCHEME):
- new_config.reset(ProxyConfigDictionary::CreateFixedServers(
- input.server, input.bypass_rules));
+ new_config = ProxyConfigDictionary::CreateFixedServers(
+ input.server, input.bypass_rules);
break;
}
result->Swap(new_config.get());

Powered by Google App Engine
This is Rietveld 408576698