Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: Fix compilation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc
diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc b/chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc
index 99c50f7f9457e3c2c9c675a9b83f1443cb930ffd..0f0d9f0c060e5c05afba1227eb6aa1dca155a72b 100644
--- a/chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc
+++ b/chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc
@@ -4,6 +4,7 @@
#include <memory>
#include <string>
+#include <utility>
#include "base/bind.h"
#include "base/callback.h"
@@ -281,7 +282,7 @@ class ArcSettingsServiceTest : public InProcessBrowserTest {
void SetProxyConfigForNetworkService(
const std::string& service_path,
const base::DictionaryValue* proxy_config) {
- ProxyConfigDictionary proxy_config_dict(proxy_config);
+ ProxyConfigDictionary proxy_config_dict(proxy_config->CreateDeepCopy());
const chromeos::NetworkState* network = chromeos::NetworkHandler::Get()
->network_state_handler()
->GetNetworkState(service_path);
@@ -509,7 +510,7 @@ IN_PROC_BROWSER_TEST_F(ArcSettingsServiceTest, TwoSourcesTest) {
std::unique_ptr<base::DictionaryValue> proxy_config(
base::MakeUnique<base::DictionaryValue>());
proxy_config->SetString("mode", ProxyPrefs::kAutoDetectProxyModeName);
- ProxyConfigDictionary proxy_config_dict(proxy_config.get());
+ ProxyConfigDictionary proxy_config_dict(std::move(proxy_config));
const chromeos::NetworkState* network = chromeos::NetworkHandler::Get()
->network_state_handler()
->DefaultNetwork();

Powered by Google App Engine
This is Rietveld 408576698