Selection Action mode triggered like a context menu

third_party/WebKit/Source/core/input/GestureManager.cpp

Index: third_party/WebKit/Source/core/input/GestureManager.cpp
diff --git a/third_party/WebKit/Source/core/input/GestureManager.cpp b/third_party/WebKit/Source/core/input/GestureManager.cpp
index 5961df0856725ea312feeb072b36ced08171d803..9a6f4ad523a2f72a9fe0b206e97c3903bf0a426c 100644
--- a/third_party/WebKit/Source/core/input/GestureManager.cpp
+++ b/third_party/WebKit/Source/core/input/GestureManager.cpp
@@ -301,6 +301,12 @@ WebInputEventResult GestureManager::HandleGestureTap(
         tapped_position_in_viewport, tapped_node,
         dom_tree_changed || style_changed);
   }
+
+  if (event_result == WebInputEventResult::kHandledSystem) {

[bokan, 2017/05/24 19:15:52]

Is a synthetic mouse up/release being kHandledSystem always indicative that we
need to show a context menu? That seems a bit fragile to me, could we send the
context menu at the place where we decide it's needed (presumably somewhere in
the text selection code?)

Also, this should be |else if|

+    frame_->GetEventHandler().SendContextMenuEventForTouchSelection(
+        kMenuSourceTouch);
+  }
+
   return event_result;
 }
 
@@ -333,7 +339,6 @@ WebInputEventResult GestureManager::HandleGestureLongPress(
   if (inner_node && inner_node->GetLayoutObject() &&
       selection_controller_->HandleGestureLongPress(hit_test_result)) {
     mouse_event_manager_->FocusDocumentView();
-    return WebInputEventResult::kHandledSystem;
   }
 
   return SendContextMenuEventForGesture(targeted_event);