Selection Action mode triggered like a context menu

third_party/WebKit/Source/core/input/GestureManager.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/input/GestureManager.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/DocumentUserGestureToken.h"
 #include "core/editing/SelectionController.h"
 #include "core/events/GestureEvent.h"
@@ skipping 283 matching lines @@
     bool style_changed =
         pre_dispatch_style_version != frame_->GetDocument()->StyleVersion();
 
     IntPoint tapped_position_in_viewport =
         frame_->GetPage()->GetVisualViewport().RootFrameToViewport(
             tapped_position);
     frame_->GetChromeClient().ShowUnhandledTapUIIfNeeded(
         tapped_position_in_viewport, tapped_node,
         dom_tree_changed || style_changed);
   }
+
+  if (event_result == WebInputEventResult::kHandledSystem) {

[bokan, 2017/05/24 19:15:52]

Is a synthetic mouse up/release being kHandledSystem always indicative that we
need to show a context menu? That seems a bit fragile to me, could we send the
context menu at the place where we decide it's needed (presumably somewhere in
the text selection code?)

Also, this should be |else if|

+    frame_->GetEventHandler().SendContextMenuEventForTouchSelection(
+        kMenuSourceTouch);
+  }
+
   return event_result;
 }
 
 WebInputEventResult GestureManager::HandleGestureLongPress(
     const GestureEventWithHitTestResults& targeted_event) {
   const WebGestureEvent& gesture_event = targeted_event.Event();
 
   // FIXME: Ideally we should try to remove the extra mouse-specific hit-tests
   // here (re-using the supplied HitTestResult), but that will require some
   // overhaul of the touch drag-and-drop code and LongPress is such a special
@@ skipping 12 matching lines @@
   if (!hit_test_contains_links &&
       mouse_event_manager_->HandleDragDropIfPossible(targeted_event)) {
     long_tap_should_invoke_context_menu_ = true;
     return WebInputEventResult::kHandledSystem;
   }
 
   Node* inner_node = hit_test_result.InnerNode();
   if (inner_node && inner_node->GetLayoutObject() &&
       selection_controller_->HandleGestureLongPress(hit_test_result)) {
     mouse_event_manager_->FocusDocumentView();
-    return WebInputEventResult::kHandledSystem;
   }
 
   return SendContextMenuEventForGesture(targeted_event);
 }
 
 WebInputEventResult GestureManager::HandleGestureLongTap(
     const GestureEventWithHitTestResults& targeted_event) {
 #if !OS(ANDROID)
   if (long_tap_should_invoke_context_menu_) {
     long_tap_should_invoke_context_menu_ = false;
@@ skipping 80 matching lines @@
   }
   return WebInputEventResult::kNotHandled;
 }
 
 WTF::Optional<WTF::TimeTicks> GestureManager::GetLastShowPressTimestamp()
     const {
   return last_show_press_timestamp_;
 }
 
 }  // namespace blink