cros: do not try to activate system tray bubble if it is in process of closing

cros: do not try to activate system tray bubble if it is in process of closing

Changes:
SystemTray::CloseSystemBubble() !activating_ is caught, reported in crbug.com/702267. Widget::IsClosed() indicates a widget is in process of closing, so we use this to do the check in ActivateBubble().
This is speculative fix for the bug.

BUG=702267
TEST=none

Review-Url: https://codereview.chromium.org/2785823002
Cr-Commit-Position: refs/heads/master@{#460616}
Committed: https://chromium.googlesource.com/chromium/src/+/85eb99035fea825bca1ecb8b12b36fb12f6065ea

[Qiang(Joe) Xu, 2017-03-29 22:47:57]

Description was changed from

==========
cros: do not try to activate system tray bubble if it is in process of closing

BUG=702267
TEST=none
==========

to

==========
cros: do not try to activate system tray bubble if it is in process of closing

Changes:
SystemTray::CloseSystemBubble() !activating_ is caught, reported in
crbug.com/702267. This CL is try to fix that. Widget::IsClosed() indicates a
widget is in process of closing, so we use this to do the check in
ActivateBubble().

BUG=702267
TEST=none as this CL is an attempted fix.
==========

[Qiang(Joe) Xu, 2017-03-29 22:47:57]

warx@chromium.org changed reviewers:
+ oshima@chromium.org

[Qiang(Joe) Xu, 2017-03-29 22:48:46]

Hi oshima@, PTAL, thanks!

[Qiang(Joe) Xu, 2017-03-29 23:14:46]

Patchset #3 (id:40001) has been deleted

[Qiang(Joe) Xu, 2017-03-29 23:15:03]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 23:16:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2017-03-30 00:39:43]

lgtm

mention that this is speculative fix for the bug in the description.

TEST=None
is fine

[Qiang(Joe) Xu, 2017-03-30 00:41:26]

Description was changed from

==========
cros: do not try to activate system tray bubble if it is in process of closing

Changes:
SystemTray::CloseSystemBubble() !activating_ is caught, reported in
crbug.com/702267. This CL is try to fix that. Widget::IsClosed() indicates a
widget is in process of closing, so we use this to do the check in
ActivateBubble().

BUG=702267
TEST=none as this CL is an attempted fix.
==========

to

==========
cros: do not try to activate system tray bubble if it is in process of closing

Changes:
SystemTray::CloseSystemBubble() !activating_ is caught, reported in
crbug.com/702267. Widget::IsClosed() indicates a widget is in process of
closing, so we use this to do the check in ActivateBubble().
This is speculative fix for the bug.

BUG=702267
TEST=none
==========

[commit-bot: I haz the power, 2017-03-30 01:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:16:08]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2017-03-30 01:16:19]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:17:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 01:23:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490836579945840,
"parent_rev": "c084fc8b9db3d90930f51a2a72f38444d2a07778", "commit_rev":
"85eb99035fea825bca1ecb8b12b36fb12f6065ea"}

[commit-bot: I haz the power, 2017-03-30 01:23:57]

Description was changed from

==========
cros: do not try to activate system tray bubble if it is in process of closing

Changes:
SystemTray::CloseSystemBubble() !activating_ is caught, reported in
crbug.com/702267. Widget::IsClosed() indicates a widget is in process of
closing, so we use this to do the check in ActivateBubble().
This is speculative fix for the bug.

BUG=702267
TEST=none
==========

to

==========
cros: do not try to activate system tray bubble if it is in process of closing

Changes:
SystemTray::CloseSystemBubble() !activating_ is caught, reported in
crbug.com/702267. Widget::IsClosed() indicates a widget is in process of
closing, so we use this to do the check in ActivateBubble().
This is speculative fix for the bug.

BUG=702267
TEST=none

Review-Url: https://codereview.chromium.org/2785823002
Cr-Commit-Position: refs/heads/master@{#460616}
Committed:
https://chromium.googlesource.com/chromium/src/+/85eb99035fea825bca1ecb8b12b3...
==========

[commit-bot: I haz the power, 2017-03-30 01:23:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/85eb99035fea825bca1ecb8b12b3...